Re: Bug in SQL/MED?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, 花田 茂 <hanada(at)metrosystems(dot)co(dot)jp>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug in SQL/MED?
Date: 2011-07-05 22:48:06
Message-ID: 1131.1309906086@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Another possibility that just occurred to me is to call the validator
> like this:
>
> if (OidIsValid(fdwvalidator))
> {
> Datum valarg = result;
>
> /* pass a null options list as an empty array */
> if (DatumGetPointer(valarg) == NULL)
> valarg = construct_empty_array(TEXTOID);
> OidFunctionCall2(fdwvalidator, valarg, ObjectIdGetDatum(catalogId));
> }

> This would avoid messing with the semantics of empty options lists
> throughout foreigncmds.c, and also avoid requiring validators to deal
> with null arguments.

Not hearing any objections, I've fixed it that way.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2011-07-05 23:59:12 Re: Crash dumps
Previous Message Tom Lane 2011-07-05 22:46:57 Re: Bug in SQL/MED?