Re: IPv6 address parsing for inet/cidr types (take II)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Graff <explorer(at)flame(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: IPv6 address parsing for inet/cidr types (take II)
Date: 2003-04-11 14:14:20
Message-ID: 11253.1050070460@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Michael Graff <explorer(at)flame(dot)org> writes:
> The first posting was held for moderator approval, which never
> happened, so I'll try this again after first subscribing.

As I recall, Paul Vixie's first attempt at this was rejected because it
undid a lot of painfully-arrived-at decisions about the I/O behavior of
these datatypes. You need to tell us exactly what you did about those
issues. (No, I don't have time to read the code to find out...)

You also need to supply some documentation updates --- code updates
alone are incomplete. I'd not have had to ask the question above if
this patch included proper documentation. The "Network Address Data
Types" and "Network Address Type Functions" pages both need to be fixed.

Some additions to the inet regression test would seem in order, too.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Patrick Welche 2003-04-11 17:27:36 Re: Modern C++ Interface
Previous Message Michael Graff 2003-04-11 10:29:43 IPv6 address parsing for inet/cidr types (take II)