Re: automatically generating node support functions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, David Rowley <dgrowleyml(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: automatically generating node support functions
Date: 2022-07-11 16:07:09
Message-ID: 1123940.1657555629@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>> could not handle type "ScanDirection" in struct "IndexScan" field
>> "indexorderdir"

> Ah, I see. Still, we could also handle that with
> push @enum_types, qw(ScanDirection);

I tried that, and it does work. The only other input file we could
get rid of that way is nodes/lockoptions.h, which likewise contributes
only a couple of enum type names. Not sure it's worth messing with
--- both ways seem crufty, though for different reasons.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-07-11 16:07:28 Re: [PATCH] Optimize json_lex_string by batching character copying
Previous Message Tom Lane 2022-07-11 15:53:26 Re: [PATCH] Optimize json_lex_string by batching character copying