Re: Very confusing installcheck behavior with PGXS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Very confusing installcheck behavior with PGXS
Date: 2016-01-07 17:49:06
Message-ID: 11232.1452188946@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> writes:
> input and output are used in only 3 places in the whole tree[1], so
> maybe the best thing to do is just rip support for that out of
> pg_regress and handle it some other way.

[ raised eyebrow ] It's not apparent to me that moving it someplace else
would reduce the net cruft any.

The real problem is that Peter just did the minimum amount of work
to get VPATH to work at all, not to get it to work in a non-surprising
way. We really need this code to be explicitly VPATH-aware, I think,
rather than overloading the inputdir and outputdir concepts in
multiple ways.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2016-01-07 17:59:17 Re: Very confusing installcheck behavior with PGXS
Previous Message Andres Freund 2016-01-07 17:45:30 Re: pglogical_output - a general purpose logical decoding output plugin