| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com> |
| Cc: | Christopher Baines <mail(at)cbaines(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format |
| Date: | 2020-05-16 19:31:07 |
| Message-ID: | 11223.1589657467@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com> writes:
> I'm wondering why there is such a distinction. We have some options:
> (a) leave it as is and document that those 2 options has no effect in
> pg_dump
> and possibly add a warning to report if someone uses it with an archive
> format;
> (b) exclude owner and tablespace from archive (it breaks compatibility but
> do
> exactly what users expect).
I think throwing a warning saying "this option does nothing" might be
a reasonable change.
I think (b) would be a break in the archive format, with unclear
consequences, so I'm not in favor of that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2020-05-16 19:32:46 | Re: Multiple FPI_FOR_HINT for the same block during killing btree index items |
| Previous Message | Euler Taveira | 2020-05-16 19:26:27 | Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format |