Re: SRF patch (was Re: [HACKERS] troubleshooting pointers)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: SRF patch (was Re: [HACKERS] troubleshooting pointers)
Date: 2002-05-19 21:27:17
Message-ID: 11212.1021843637@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Joe Conway <mail(at)joeconway(dot)com> writes:
> Here's a small patch to ExecFunctionReScan. It was clearing
> scanstate->csstate.cstate.cs_ResultTupleSlot
> when I think it should have been clearing
> scanstate->csstate.css_ScanTupleSlot

Why do you think that? To the extent that other rescan routines are
clearing anything, they're clearing ResultTupleSlot.

> although there is no discernable (at least to me) difference either way.

My guess is that it's pretty much a no-op, since the slot will get
cleared and re-used on the next call anyway.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Burton 2002-05-19 21:28:16 Re: Exposed function to find table in schema search list?
Previous Message Joe Conway 2002-05-19 21:25:16 Re: Exposed function to find table in schema search list?

Browse pgsql-patches by date

  From Date Subject
Next Message Joe Conway 2002-05-19 21:40:30 Re: SRF patch (was Re: [HACKERS] troubleshooting pointers)
Previous Message Tom Lane 2002-05-19 21:22:34 Re: [PATCHES] SRF patch (was Re: troubleshooting pointers)