Re: Ensure that STDERR is empty during connect_ok

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jacob Champion <pchampion(at)vmware(dot)com>
Subject: Re: Ensure that STDERR is empty during connect_ok
Date: 2022-02-02 15:01:28
Message-ID: 1118264.1643814088@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> As part of the NSS patchset, quite a few bugs (and NSS quirks) were found by
> inspecting STDERR in connect_ok and require it to be empty. This is not really
> NSS specific, and could help find issues in other libraries as well so I
> propose to apply it regardless of the fate of the NSS patchset.

+1

> (The change in the SCRAM tests stems from this now making all testruns have the
> same number of tests. While I prefer to not plan at all and instead run
> done_testing(), doing that consistently is for another patch, keeping this with
> the remainder of the suites.)

+1 to that too, counting the tests is a pretty useless exercise.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Borisov 2022-02-02 15:10:23 Re: Add 64-bit XIDs into PostgreSQL 15
Previous Message Alvaro Herrera 2022-02-02 15:01:14 Re: Ensure that STDERR is empty during connect_ok