Re: Have postgres.bki self-identify

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Have postgres.bki self-identify
Date: 2025-03-20 20:33:08
Message-ID: 1117526.1742502788@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Mar 20, 2025 at 3:47 PM David G. Johnston
> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>> While trying to find postgres.bki in my build directory searching for the file name didn't work because there is no comment in the file containing the file name; like there is in every other file we write or generate, including the related *_d.h files. Add it.

> I'm not a fan of making it a policy that everyone has to do this. I'd
> rather see us remove filenames from some places where they cause
> maintenance overhead for little benefit. If somebody wants to find
> postgres.bki, I guess you can just "find . -name postgres.bki -print"

While I don't care much about the filename per se, I do note that
we embed copyright notices into most generated files. Why
not this one?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2025-03-20 20:33:26 Re: [PoC] Federated Authn/z with OAUTHBEARER
Previous Message Tom Lane 2025-03-20 20:27:13 Re: Not-terribly-safe checks for CRC intrinsic support