Re: It is not documented that pg_promote can exit standby mode

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: ikedamsh <ikedamsh(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: It is not documented that pg_promote can exit standby mode
Date: 2020-04-21 05:07:09
Message-ID: 1116f41c-ae6e-1217-0bb6-87c176ece969@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020/04/20 20:38, Fujii Masao wrote:
>
>
> On 2020/04/18 2:46, Tom Lane wrote:
>> Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
>>> Thanks for the report and the patch! It looks good to me.
>>> Barring any objection, I will commit this patch.
>>
>> It might be worth writing "<function>pg_promote()</function> is called"
>> (adding parentheses) to make it clearer that a function is being
>> referred to.  No objection otherwise.
>
> Yes. Also Masahiro-san reported me, off-list, that there are other places
> where pg_promote is mentioned without parentheses. I think it's better to
> add parentheses there. Attached is the updated version of the patch.

Pushed. Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2020-04-21 05:23:44 Re: Parallel Append can break run-time partition pruning
Previous Message Tom Lane 2020-04-21 04:58:20 Re: Fix for pg_statio_all_tables