Re: patches for items from TODO list

From: Markus Bertheau <twanger(at)bluetwanger(dot)de>
To: Sergey Ten <sergey(at)sourcelabs(dot)com>
Cc: "'Bruce Momjian'" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "'Christopher Kings-Lynne'" <chriskl(at)familyhealth(dot)com(dot)au>, pgsql-hackers(at)postgresql(dot)org, jason(at)sourcelabs(dot)com
Subject: Re: patches for items from TODO list
Date: 2005-05-18 00:59:38
Message-ID: 1116377979.7656.5.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Dnia 13-05-2005, pią o godzinie 16:01 -0700, Sergey Ten napisał(a):

> <?xml version='1.0'?>
> <table>
> <row>
> <col name='col1' null='n'>Jackson, Sam</col>
> <col name='col2' null='n'>\h</col>
> </row>
> <row>
> <col name='col1' null='n'>It is &quot;perfect&quot;.</col>
> <col name='col2' null='n'>&#09;</col>
> </row>
> <row>
> <col name='col1' null='n'></col>
> <col name='col2' null='y'></col>
> </row>
> </table>

Why didn't you do something to the effect of

<?xml version='1.0'?>
<table>
<cols>
<col name='col1'/>
<col name='col2'/>
</cols>
<row>
<col null='n'>Jackson, Sam</col>
<col null='n'>\h</col>
</row>
<row>
<col null='n'>It is &quot;perfect&quot;.</col>
<col null='n'>&#09;</col>
</row>
<row>
<col null='n'></col>
<col null='y'></col>
</row>
</table>

This avoids repeating the column names in every row, which don't change
over the rows anyway. By reducing redundant information it also makes
structurally invalid XML less likely (whether that is relevant depends
on what people do with the XML data).

Also you could encode the XML output as UTF-8, which would make the
files more readable for humans if the text data is not ASCII.

Markus

--
Markus Bertheau <twanger(at)bluetwanger(dot)de>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2005-05-18 01:00:48 Re: Learning curves and such (was Re: pgFoundry)
Previous Message Neil Conway 2005-05-18 00:46:18 Re: Learning curves and such (was Re: pgFoundry)

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2005-05-18 02:11:17 Re: patches for items from TODO list
Previous Message Alvaro Herrera 2005-05-17 23:16:12 Re: Refactoring in lock.c