Re: compiling with ssl without thread safety still broken

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kris Jurka <books(at)ejurka(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: compiling with ssl without thread safety still broken
Date: 2004-03-27 03:12:45
Message-ID: 1116.1080357165@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Kris Jurka <books(at)ejurka(dot)com> writes:
> Compiling with ssl without thread safety still broken.
> pq_initssllib is being incorrectly guarded by ENABLE_THREAD_SAFETY.

Not to mention that it has NO business being declared at some random
place in the middle of the file. Fix committed, but some further review
of this mare's-nest seems warranted.

This file is getting to be a poster child for the reasons not to use
#ifdefs :-(

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2004-03-27 03:45:32 Removing cruft in access/transam/xact.c
Previous Message Magnus Hagander 2004-03-26 23:22:31 Re: APC/socket fix (final?)