| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Use LEFT JOINs in some system views in case referenced row doesn |
| Date: | 2016-09-12 02:38:23 |
| Message-ID: | 11143.1473647903@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> Indeed, and the query field does not have much more meaning for a WAL
> sender. So I'd propose the attached for 9.6 and HEAD. I have thought
> about reporting that to pgstat in StartReplication(), but as there is
> some error handling there I'd think that WalSndLoop() is a better
> place to call pgstat_report_activity, as per the attached.
As long as it's a fixed string there's no reason to set it repeatedly,
so this placement looks fine for now. We can reconsider when/if we
make it variable and decide what is going to drive it.
On reflection, maybe s/walsender/WAL sender/? It doesn't look like
we really use the word "walsender" in user-facing docs.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-09-12 02:46:03 | Re: Re: [COMMITTERS] pgsql: Use LEFT JOINs in some system views in case referenced row doesn |
| Previous Message | Michael Paquier | 2016-09-12 02:27:20 | Re: Re: [COMMITTERS] pgsql: Use LEFT JOINs in some system views in case referenced row doesn |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-09-12 02:38:51 | Re: Forbid use of LF and CR characters in database and role names |
| Previous Message | Michael Paquier | 2016-09-12 02:27:20 | Re: Re: [COMMITTERS] pgsql: Use LEFT JOINs in some system views in case referenced row doesn |