Re: prepared statements don't log arguments?

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Oliver Jowett <oliver(at)opencloud(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Palle Girgensohn <girgen(at)pingpong(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: prepared statements don't log arguments?
Date: 2005-04-11 20:09:24
Message-ID: 1113250164.16721.1246.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, 2005-04-10 at 17:54 +1200, Oliver Jowett wrote:
> Simon Riggs wrote:
>
> > I've got a patch to submit that logs the EXEC phase, so you get just the
> > SQL, not the parameters. [...]

Just testing against cvstip and wrapping now...

> I assume this replaces the current logging on Parse to avoid duplicate
> logging?

Well, I'm open to discussion, but that isn't what the patch does.

My thinking was to add functionality, not take it away. We currently
support V2 and V3 connections, so we need to continue to log V2
statements as well as V3 exec phase.

> What happens on syntax errors? It's useful to log the statement that
> failed, but you will need some trickery there since if the Parse logging
> goes away, we won't have logged anything at the point the error is
> generated.

Well, those are problems I've not had to solve.

Best Regards, Simon Riggs

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2005-04-11 20:09:43 Re: probably needless linking against readline and ncurses
Previous Message Rémi Zara 2005-04-11 19:33:38 NetBSD mac68k crashing on union regression test