| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A performance issue with Memoize |
| Date: | 2024-01-26 21:09:00 |
| Message-ID: | 1113188.1706303340@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Sat, 27 Jan 2024 at 09:41, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> drongo and fairywren are consistently failing the test case added
>> by this commit. I'm not quite sure why the behavior of Memoize
>> would be platform-specific when we're dealing with integers,
>> but ...
> Maybe snprintf(buf, "%.*f", 0, 5.0 / 2.0); results in "3" on those
> rather than "2"?
> Looking at the code in fmtfloat(), we fallback on the built-in snprintf.
Maybe ... I don't have a better theory.
> I can try changing the unique1 < 5 to unique1 < 4 to see that's more stable.
Worth a try.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Eli Schwartz | 2024-01-26 21:18:58 | Re: make dist using git archive |
| Previous Message | David Rowley | 2024-01-26 21:02:51 | Re: A performance issue with Memoize |