Quick Links

Re: PATCH: improve sorting in the Data Editor

From:	"J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru>
To:	Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc:	pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject:	Re: PATCH: improve sorting in the Data Editor
Date:	2015-08-12 16:06:04
Message-ID:	111078738.20150812190604@mail.ru
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Thread:
Lists:	pgadmin-hackers

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html><head><title></title>
<META http-equiv=Content-Type content="text/html; charset=utf-8">
<meta http-equiv="Content-Style-Type" content="text/css">
<style type="text/css"></style>
</head>
<body>

Ashesh, will you commit this, please?
 
 
Thursday, August 6, 2015, 12:16:37 PM, you wrote:
 
<div><table border=0 cellpadding=1 cellspacing=2>
<tr valign=top>
<td width=12 style="background-color: #0000ff;">
>
</td>
<td width=1125 style="background-color: #ffffff;">
Hi,
 
In this case patch looks good to me.
 
 
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
 
 
On Thu, Aug 6, 2015 at 2:22 PM, Dave Page <<a class=rvts8 href="mailto:dpage(at)pgadmin(dot)org">dpage(at)pgadmin(dot)org</a>> wrote:
 
 
 
 
 
On Wed, Aug 5, 2015 at 6:20 PM, Sanket Mehta <<a class=rvts8 href="mailto:sanket(dot)mehta(at)enterprisedb(dot)com">sanket(dot)mehta(at)enterprisedb(dot)com</a>> wrote:
 
Hi,
 
I have reviewed the patch and below is analysis.
 
- Behaviour of sorting in data editor before applying the patch is as below:
 
By default table is sorted by PK/OID in ascending order.
when user select any other column to sort the table, that column gets the second priority for sorting the table like i.e.order by col_pk, col_column1 where col_pk is column having PK and col_column1 is any other ordinary column.
 
- below is the behaviour I have found after applying the patch:
 
By default table is sorted by PK/OID in ascending order.
When user selects any other column default sorting is removed and table is getting sorted by newly selected column.
But after this if user wants to sort the table by PK or any other column it will have the same behaviour like it has before applying the patch. i.e. order by col_column1, col_PK where col_column1 and col_PK are same as explained above. It will not sort the table by newly selected column(col_PK) because sorting of older column(col_column1) is still in effect and has the higher priority.
 
This will also confuse the user.
 
So according to me current behaviour of sorting of table data in pgadmin is acceptable.
 
Dave, 
Do you have any other thoughts on it?
 
I think J.F's patch makes sense. It is a little more complex logically speaking, but I also think it's more likely what the user would expect to happen.
 
 
 
 
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
 
 
On Mon, Aug 3, 2015 at 11:07 AM, Sanket Mehta <<a class=rvts8 href="mailto:sanket(dot)mehta(at)enterprisedb(dot)com">sanket(dot)mehta(at)enterprisedb(dot)com</a>> wrote:
 
Sure Ashesh.
 
 
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
 
 
On Mon, Aug 3, 2015 at 10:49 AM, Ashesh Vashi <<a class=rvts8 href="mailto:ashesh(dot)vashi(at)enterprisedb(dot)com">ashesh(dot)vashi(at)enterprisedb(dot)com</a>> wrote:
 
Sanket,
 
Can you please review it?
 
 
 
--
Thanks & Regards,
 
Ashesh Vashi
EnterpriseDB INDIA: <a class=rvts10 href="http://www.enterprisedb.com">Enterprise PostgreSQL Company</a>
 
<a class=rvts11 href="http://www.linkedin.com/in/asheshvashi">http://www.linkedin.com/in/asheshvashi</a>
 
 
On Sun, Aug 2, 2015 at 3:49 PM, J.F. Oster <<a class=rvts8 href="mailto:jinfroster(at)mail(dot)ru">jinfroster(at)mail(dot)ru</a>> wrote:
Hello,
 
Here is a small improvement about sorting in the Data editor.
 
Problem:
If a table has a PK or OIDs, it gets sorted by PK/OID by default.
When a user wants to sort by any other column, he has first to click
"Remove sort" in the context menu, and only then click "Sort
ascending"(descending) on column of his choice.
 
If he doesn't remove the default sort, he will get no effect and
probably be puzzled for the first time until guesses that he makes
  ORDER BY column_pk, column_of_choice
which is totally useless.
The need to "Remove sort" each time is annoying.
 
Solution:
When a user chooses to sort by some column, we must discard the
default sort order.
 
Please see the attached patch.
Thanks.
 
--
Best regards,
 J.F.
 
--
Sent via pgadmin-hackers mailing list (<a class=rvts8 href="mailto:pgadmin-hackers(at)postgresql(dot)org">pgadmin-hackers(at)postgresql(dot)org</a>)
To make changes to your subscription:
<a class=rvts8 href="http://www.postgresql.org/mailpref/pgadmin-hackers">http://www.postgresql.org/mailpref/pgadmin-hackers</a>
 
 
 
 
 
-- 
 
Dave Page
Blog: <a class=rvts8 href="http://pgsnake.blogspot.com">http://pgsnake.blogspot.com</a>
Twitter: @pgsnake
 
EnterpriseDB UK: <a class=rvts8 href="http://www.enterprisedb.com">http://www.enterprisedb.com</a>
The Enterprise PostgreSQL Company
</td>
</tr>
</table>
</div>
 
 
 
 
-- 
Best regards,
 J.F.

</body></html>

Attachment	Content-Type	Size
unknown_filename	text/html	9.4 KB

In response to

Re: PATCH: improve sorting in the Data Editor at 2015-08-06 09:16:37 from Sanket Mehta

Responses

Re: PATCH: improve sorting in the Data Editor at 2015-09-02 05:31:01 from J.F. Oster

Browse pgadmin-hackers by date

	From	Date	Subject
Next Message	prasad.s	2015-08-13 06:36:57	Re: Patch : PGPASSFILE fix
Previous Message	Ashesh Vashi	2015-08-11 13:50:58	pgAdmin 4 commit: Fixed few bugs and changed the node create/edit view