Re: query_planner() API change

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: query_planner() API change
Date: 2013-08-05 00:57:12
Message-ID: 11104.1375664232@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sun, Aug 4, 2013 at 6:20 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I think it's time to bite the bullet and *not* pass back completed paths.
>> What's looking more attractive now is to just pass back the top-level
>> RelOptInfo ("final_rel" in query_planner()).

> I tend to think this is a pretty good plan.

I looked around a little more and noted that this would complicate the
special-case handling of an empty join tree (viz, "SELECT 2+2"). Right
now query_planner() just has to make the appropriate Result path and it's
done. We'd have to create a dummy RelOptInfo representing an empty set
of relations, which is a bit weird but probably not too unreasonable
when all's said and done.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-08-05 01:07:02 Re: PostgreSQL and ASLR on Linux
Previous Message Andres Freund 2013-08-05 00:54:05 Re: PostgreSQL and ASLR on Linux