| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Superuser can permit passwordless connections on postgres_fdw |
| Date: | 2019-12-21 03:17:20 |
| Message-ID: | 11100.1576898240@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Fri, Dec 20, 2019 at 02:42:22PM -0500, Tom Lane wrote:
>> I notice in testing this that the "nosuper" business added by
>> 6136e94dc is broken in more ways than what the buildfarm is
>> complaining about: it leaves the role around at the end of the
>> test.
> Roles left behind at the end of a test are annoying. Here is an idea:
> make pg_regress check if any roles prefixed by "regress_" are left
> behind at the end of a test. This will not work until test_pg_dump is
> cleaned up, just a thought.
Yeah, it's sort of annoying that the buildfarm didn't notice this
aspect of things. I'm not sure I want to spend cycles on checking
it in every test run, though.
Maybe we could have -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS
enable a check for that aspect along with what it does now?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2019-12-21 17:44:48 | pgsql: docs: clarify handling of column lists in COPY TO/FROM |
| Previous Message | Michael Paquier | 2019-12-21 02:18:06 | Re: pgsql: Superuser can permit passwordless connections on postgres_fdw |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-12-21 06:38:16 | Re: Preserve versions of initdb-created collations in pg_upgrade |
| Previous Message | Michael Paquier | 2019-12-21 02:48:34 | Re: automating pg_config.h.win32 maintenance |