Re: Refactoring lock.c

From: Neil Conway <neilc(at)samurai(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Refactoring lock.c
Date: 2005-02-03 00:00:08
Message-ID: 1107388808.26960.31.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Wed, 2005-02-02 at 21:41 +0200, Heikki Linnakangas wrote:
> There's two almost identical pieces of code in LockRelease and
> LockReleaseAll that do the opposite of GrantLock.
>
> Here's a small patch that replaces those pieces with a static UnGrantLock
> function.

LockReleaseAll() did not update the holdMask bits for a released
proclock, but it will do so now. That's okay because we're removing the
proclock, right?

Barring any objections, I'll apply this to HEAD today or tomorrow.

-Neil

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-02-03 03:16:10 Re: libpq API incompatibility between 7.4 and 8.0
Previous Message Tom Lane 2005-02-02 23:53:08 Re: libpq API incompatibility between 7.4 and 8.0