Re: heap_modifytuple

From: Neil Conway <neilc(at)samurai(dot)com>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: heap_modifytuple
Date: 2005-01-27 23:24:28
Message-ID: 1106868268.3226.76.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Wed, 2004-09-08 at 16:31 -0400, Alvaro Herrera wrote:
> Here is a simple patch that changes heap_modifytuple to require a
> TupleDesc instead of a Relation (driven off a comment in the same
> function).

Patch applied to HEAD. I went to the trouble of checking the call sites
of heap_modifytuple() and using the TupleDesc of the relation if we have
already fetched it, rather than calling RelationGetDescr() again.

Thanks for the patch.

-Neil

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2005-01-27 23:36:19 Re: Move get_grosysid() to utils/cache/lsyscache.c
Previous Message Mark Wong 2005-01-27 21:30:25 Re: [HACKERS] WAL: O_DIRECT and multipage-writer