| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: add regression test for #1433 |
| Date: | 2005-01-25 03:27:12 |
| Message-ID: | 1106623632.1780.91.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Mon, 2005-01-24 at 22:22 -0500, Tom Lane wrote:
> It might be better to make the tables TEMP tables --- there are some
> regression tests that depend on the set of existing tables, IIRC.
> Otherwise ok.
True, although those kind of dependencies usually cause an obvious test
failure (which this patch doesn't cause). I've been thinking that
there's some value in keeping database objects creating by regression
tests around, so that we get better pg_dump coverage (a quick and dirty
pg_dump test is to dump the database created by "make installcheck" and
restore it). Admittedly this is pretty primitive, but it's better than
nothing.
[ Sorry for applying the patch already, I hadn't received your mail ]
-Neil
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kris Jurka | 2005-01-25 06:13:07 | add soundex difference function to contrib/fuzzystrmatch |
| Previous Message | Neil Conway | 2005-01-25 03:23:14 | Re: add regression test for #1433 |