From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: [HACKERS] Bgwriter behavior |
Date: | 2004-12-31 00:04:48 |
Message-ID: | 1104451488.3978.249.camel@localhost.localdomain |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On Mon, 2004-12-27 at 22:21, Bruce Momjian wrote:
> Should we consider at least adjusting the meaning of bgwriter_percent?
Yes. As things stand, this is the only change that seems safe.
Here's a very short patch that implements this change within BufferSync
in bufmgr.c
- No algorithm changes
- No error message changes
- Only change is the call to StrategyDirtyBufferList is made using the
maximum number of buffers that will be cleaned, rather than uselessly
trawling through all of shared_buffers
This changes the meaning of bgwriter_percent from "percent of dirty
buffers" to "percent of shared_buffers". The default settings of 1% of
1000 buffers gives up to 10 dirty block writes every 250ms
Benefit: allows performance tuning by increases options for setting
bgwriter_delay which would otherwise have an ineffectually high minimum
setting
Risk: low
1-line doc patch to follow, if this is approved.
--
Best Regards, Simon Riggs
Attachment | Content-Type | Size |
---|---|---|
bg_v8.patch | text/x-patch | 2.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-12-31 01:14:39 | Re: [HACKERS] Bgwriter behavior |
Previous Message | Manfred Koizar | 2004-12-30 23:17:09 | Re: Shared row locking |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-12-31 01:14:39 | Re: [HACKERS] Bgwriter behavior |
Previous Message | Tom Lane | 2004-12-30 21:49:24 | Re: Win32 version numbers not correct (again, but this one is easy) |