Re: pgsql: Fix incorrect format placeholder.

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Tue, Nov 09, 2021 at 12:19:36AM -0500, Tom Lane wrote:
>> Umm ... florican and dangomushi spotted it. Maybe we need a 32-bit
>> machine with -Werror?

> Indeed, I can see it in the logs of dangomushi. I could add a -Werror
> there, but there are also a bunch of warnings generated by plperl.

Yeah, we had complaints before about -Wcompound-token-split-by-macro
warnings.

> I'd rather keep --with-perl and clang, and there seems to be a fix
> regarding that stuff in upstream:
> https://www.nntp.perl.org/group/perl.perl5.changes/2021/07/msg57758.html

I figured the Perl guys would do something about it, but it will be a
very long time before that propagates everywhere. Maybe we should
teach configure to add -Wno-compound-token-split-by-macro? By my
count there are now five buildfarm members besides dangomushi that
are producing these warnings, and I think the number is going to
go up before it goes down.

(Meanwhile, I guess I could enable -Werror on florican.)

regards, tom lane