From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Erik Rijkers <er(at)xs4all(dot)nl>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
Subject: | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |
Date: | 2017-03-30 04:15:59 |
Message-ID: | 10990.1490847359@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> New Patch v29: Now with less coverage!
> Patch applies cleanly. Make check ok. Feature still works!
I've been hacking on this for about two full days now, and have gotten
it to a point where I think it's committable. Aside from cosmetic
changes, I've made it behave reasonably for cases where \if is used
on portions of a query, for instance
SELECT
\if :something
var1
\else
var2
\endif
FROM table;
which as I mentioned a long time ago is something that people will
certainly expect to work. I also cleaned up a lot of corner-case
discrepancies between how much text is consumed in active-branch and
inactive-branch cases (OT_FILEPIPE is a particularly nasty case in that
regard :-()
I plan to read this over again tomorrow and then push it, if there are
not objections/corrections.
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
psql-if-v30.patch | text/x-diff | 113.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Mengxing Liu | 2017-03-30 04:17:22 | Re: Guidelines for GSoC student proposals / Eliminate O(N^2) scaling from rw-conflict tracking in serializable transactions |
Previous Message | Vitaly Burovoy | 2017-03-30 04:09:46 | Re: sequence data type |