From: | Oliver Elphick <olly(at)lfix(dot)co(dot)uk> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Ian Barwick <barwick(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: 8.0b4: COMMIT outside of a transaction echoes |
Date: | 2004-10-27 14:59:21 |
Message-ID: | 1098889161.32765.2.camel@linda |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, 2004-10-26 at 21:42 -0400, Bruce Momjian wrote:
> > test=> begin;
> > BEGIN
> > test=> commit;
> > COMMIT
> > test=> commit;
> > WARNING: there is no transaction in progress
> > ROLLBACK
> >
> > Is there any reason ROLLBACK and not COMMIT is echoed here?
>
> Because the transaction was not committed, but rather rolled back.
It's still a misleading message; in those circumstances, how about
returning "NO ACTION" instead?
--
Oliver Elphick olly(at)lfix(dot)co(dot)uk
Isle of Wight http://www.lfix.co.uk/oliver
GPG: 1024D/A54310EA 92C8 39E7 280E 3631 3F0E 1EC0 5664 7A2F A543 10EA
========================================
"If a man abide not in me, he is cast forth as a
branch, and is withered; and men gather them, and cast
them into the fire, and they are burned."
John 15:6
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-10-27 15:16:53 | Re: rmtree() failure on Windows |
Previous Message | Andrew Dunstan | 2004-10-27 14:50:19 | Re: rmtree() failure on Windows |