Re: hash_create(): check return code

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: hash_create(): check return code
Date: 2004-10-22 06:55:27
Message-ID: 1098428127.6602.317.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Fri, 2004-10-22 at 16:13, Tom Lane wrote:
> There are no places where hash_create is called before elog() is
> functional.

Well, it's invoked from the statistics collector, which avoids doing
elog(ERROR) for some reason. But my guess is that it should be workable
to get elog(ERROR) / elog(FATAL) working in the statistics collector,
and it will mean a cleanup of existing code as well (which laboriously
invokes elog(LOG) followed by exit(1)). I'm working on that now...

-Neil

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-10-22 07:13:25 Re: hash_create(): check return code
Previous Message Tom Lane 2004-10-22 06:13:59 Re: hash_create(): check return code