additional GCC warning flags

From: Neil Conway <neilc(at)samurai(dot)com>
To: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: additional GCC warning flags
Date: 2004-10-18 04:24:12
Message-ID: 1098073451.22986.143.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

This patch adds code to "configure" to check if GCC supports the
following warning flags: -Wdeclaration-after-statement (GCC 3.4+),
-Wold-style-definition (GCC 3.4+), and -Wendif-labels (GCC 3.3+). Any of
these options that are supported by $CC are added to $CFLAGS. The patch
also removes -Wmissing-declarations from the default CFLAGS, on the
grounds that it is (I believe) redundant when -Wmissing-prototypes is
also specified.

(I didn't mention -Wendif-labels in my mail to -hackers, but it should
be pretty innocuous: "Warn whenever an #else or an #endif are followed
by text.")

This patch updates configure.in and configure (I re-ran autoconf 2.53).
It doesn't introduce any additional warning messages locally (Linux, GCC
3.4), but might do so on some platforms (the code in src/port/ is likely
to trigger some warnings, I think). Because of that, I think it is
probably best to save this for 8.1

-Neil

Attachment Content-Type Size
conf_gcc_warn-2.patch text/x-patch 9.8 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Zhenbang Wei 2004-10-18 06:47:09 pg_config-zh_TW.po for 8.0
Previous Message Andrew Dunstan 2004-10-17 21:44:56 Re: strange result from contrib/seg regression on windows