outdated comment in table_tuple_update definition

From: Sergei Kornilov <sk(at)zsrv(dot)org>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: outdated comment in table_tuple_update definition
Date: 2025-02-06 19:00:17
Message-ID: 1097041738868417@zxq47dct3nfd6lzq.sas.yp-c.yandex.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello

I noticed that the comment for the table_tuple_update function (src/include/access/tableam.h) describes the update_indexes parameter as boolean:

* update_indexes - in success cases this is set to true if new index entries
* are required for this tuple

Although this parameter is an enum of three values.

I found that the parameter type was changed by commit 19d8e23 (Ignore BRIN indexes when checking for HOT updates), but the comment was not updated. Looks like oversight.

* update_indexes - in successful cases, used to determine which index types
* require new index entries for this tuple

Something like this?

regards, Sergei

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2025-02-06 19:08:03 Re: Optimization for lower(), upper(), casefold() functions.
Previous Message Tomas Vondra 2025-02-06 18:48:10 Re: Adjusting hash join memory limit to handle batch explosion