| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: void * cast cleanup |
| Date: | 2004-09-27 02:03:07 |
| Message-ID: | 1096250587.25688.724.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Mon, 2004-09-27 at 11:49, Tom Lane wrote:
> I'm a bit concerned about introducing warnings from not-quite-with-it
> compilers. Are there any still out there that would treat this as a
> bogus conversion?
Since this is defined by C89, I think we're okay assuming the compiler
can handle it. In any case, a compiler that doesn't comply with the
standard on this issue would issue hundreds of warnings/errors trying to
compile the rest of the PG tree (e.g. the vast majority of pfree() call
sites that don't bother with the explicit cast), so I don't think this
change makes the situation materially worse.
-Neil
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Conway | 2004-09-27 04:02:36 | Re: void * cast cleanup |
| Previous Message | Tom Lane | 2004-09-27 01:49:35 | Re: void * cast cleanup |