Re: pg_terminate_backend() issues

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_terminate_backend() issues
Date: 2008-04-16 17:06:07
Message-ID: 10954.1208365567@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> The closest thing I can think of to an automated test is to run repeated
>> sets of the parallel regression tests, and each time SIGTERM a randomly
>> chosen backend at a randomly chosen time. Then see if anything "funny"

> Yep, that was my plan, plus running the parallel regression tests you
> get the possibility of >2 backends.

I was intentionally suggesting only one kill per test cycle. Multiple
kills will probably create an O(N^2) explosion in the set of possible
downstream-failure deltas. I doubt you'd really get any improvement
in testing coverage to justify the much larger amount of hand validation
needed.

It also strikes me that you could make some simple alterations to the
regression tests to reduce the set of observable downstream deltas.
For example, anyplace where a test loads a table with successive INSERTs
and that table is used by later tests, wrap the INSERT sequence with
BEGIN/END. Then there is only one possible downstream delta (empty
table) and not N different possibilities for an N-row table.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2008-04-16 17:19:01 Re: pg_terminate_backend() issues
Previous Message Bruce Momjian 2008-04-16 16:51:23 Re: pg_terminate_backend() issues

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-04-16 17:12:04 Re: Lessons from commit fest
Previous Message Chris Browne 2008-04-16 16:55:46 Re: Lessons from commit fest