Re: pgsql-server: Add ALTER INDEX, particularly for

From: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
To: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server: Add ALTER INDEX, particularly for
Date: 2004-08-25 14:18:52
Message-ID: 1093443532.16499.393.camel@camel
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Shouldn't the regression tests reflect that?

Robert Treat

On Tue, 2004-08-24 at 22:31, Gavin Sherry wrote:
> Yes
>
> On Tue, 24 Aug 2004, Robert Treat wrote:
>
> > I think I missed this in the earlier patches, but does the alter table syntax
> > still work for indexes in addition to the new syntax?
> >
> > On Saturday 21 August 2004 22:47, Gavin Sherry wrote:
> > > Here is a change to the alter_table regression test to use ALTER INDEX ...
> > > RENAME instead of ALTER TABLE ... RENAME in the case of an index renaming.
> > > Its probably not the right place for it, but I'm not sure where is the
> > > right place for it.
> > >
> > > Thanks,
> > >
> > > Gavin
> > >
> > > On Sat, 21 Aug 2004, Tom Lane wrote:
> > > > Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> writes:
> > > > > Thanks for spotting this sloppy work. Basically, I cropped my diff
> > > > > because there was lots of unrelated code in the work space. But I was a
> > > > > little too hard and culled allfiles.sgml, alter.c, equal/copyfuncs.c
> > > > > and analyze.c.
> > > >
> > > > I was wondering if something like that might have happened --- I know
> > > > you know better on all these points ;-)
> > > >
> > > > > I was getting together a patch against HEAD but I just noticed that you
> > > > > fixed this. Thanks.
> > > >
> > > > Yeah, I think everything is fixed in CVS tip. Let me know if there was
> > > > anything I missed.
> > > >
> > > > regards, tom lane
> > > >
> > > > ---------------------------(end of broadcast)---------------------------
> > > > TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
> > > >
> > > >
> > > > !DSPAM:4127e64e43221930617052!
> >
> > --
> > Robert Treat
> > Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL
> >
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
--
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Dennis Bjorklund 2004-08-25 18:36:56 Re: [COMMITTERS] pgsql-server: Rearrange pg_subtrans
Previous Message Jan Wieck 2004-08-25 11:29:57 Re: [COMMITTERS] pgsql-server: Rearrange pg_subtrans handling