Re: Bug: psql misquotes constraints

From: Rod Taylor <pg(at)rbt(dot)ca>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug: psql misquotes constraints
Date: 2004-07-12 01:36:42
Message-ID: 1089596202.58812.16.camel@jester
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I remember a thread about pretty-print functions. Are those used? This
is probably the best place to put the fix, since they already munge
things for display purposes.

On Sun, 2004-07-11 at 21:33, Christopher Kings-Lynne wrote:
> It should be done, otherwise you cannot copy and paste foreign key
> creation code from the psql output :)
>
> Chris
>
> Bruce Momjian wrote:
>
> > I can do that for 7.6. Is it worth it? Is it a TODO?
> >
> >
> > ---------------------------------------------------------------------------
> >
> > Christopher Kings-Lynne wrote:
> >
> >>>As a result of the constraint output functions being shared between
> >>>pg_dump and psql, some of the output is mis-quoted in the display area
> >>>for columns including quotes. Notice it's correct in the table Column
> >>>list, but the constraint has the escaped versions.
> >>
> >>It's misquoted because psql DOES NOT share the fmtId function with
> >>pg_dump. It simply puts double quotes around it. If you can fix psql
> >>so that it is able to link to the fmtId function, then you can easily
> >>fix the problem.
> >>
> >>Chris
> >>
> >>
> >>---------------------------(end of broadcast)---------------------------
> >>TIP 8: explain analyze is your friend
> >>
> >
> >

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rod Taylor 2004-07-12 01:40:22 Re: Bug: psql misquotes constraints
Previous Message Christopher Kings-Lynne 2004-07-12 01:34:52 Re: Bug: psql misquotes constraints