Re: pidfile location missing after restarting crashed server in 8.1

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pidfile location missing after restarting crashed server in 8.1
Date: 2005-10-26 19:39:37
Message-ID: 10859.1130355577@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Tom Lane wrote:
>> Yeah: it's now being accessed by a relative path (relative to $PGDATA,
>> which we have already chdir'd into at this point).

> So we should include PGDATA in the error message (DataDir actually, I
> guess).

I don't think that follows. The code prints exactly the path name it's
using to access the file, and I think that's exactly what it should
print. Are we going to editorialize similarly on every other message
that includes a file name?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Treat 2005-10-26 19:41:23 Re: pidfile location missing after restarting crashed server in 8.1
Previous Message Tom Lane 2005-10-26 19:35:20 Re: add_missing_from breaks existing views