make 'PrivateRefCount' 32 bits wide

From: Neil Conway <neilc(at)samurai(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: make 'PrivateRefCount' 32 bits wide
Date: 2004-04-21 19:57:47
Message-ID: 1082577467.7010.40.camel@tokyo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

This patch changes PrivateRefCount and LocalRefCount in the bufmgr from
being arrays of long to arrays of int32, per earlier discussion. This
should save a little memory on 64LP machines, and there's no way we need
to track > 2^31 references to a single buffer.

I also fixed the rather widespread assumption that a BufferDesc's
refcount is signed; it is not (and hence the correct printf formatting
code is %u, not %d).

I also changed ShowPinTrace to a bool, and removed some multi-line
string literals (yuck!)

Barring any objections, I intend to apply this patch within 24 hours.

-Neil

Attachment Content-Type Size
buffer-refcount-tweak-1.patch text/x-patch 13.2 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-04-22 01:54:09 Re: PSQLRC environment variable.
Previous Message Neil Conway 2004-04-21 19:28:57 Re: doc improv: backup/restore