Re: Updated version of contrib/xml (at last)

From: John Gray <jgray(at)azuli(dot)co(dot)uk>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Updated version of contrib/xml (at last)
Date: 2004-03-05 19:58:13
Message-ID: 1078516692.3432.14.camel@adzuki
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Thu, 2004-03-04 at 23:29 -0500, Bruce Momjian wrote:
> Christopher Kings-Lynne wrote:
> >
> >
> > Bruce Momjian wrote:
> >
> > > I moved your new version into /contrib/xml2, and kept /contrib/xml
> > > unchanged.
> >
> > There's just one last thing - are both xml and xml2 totally disjoint?
> > eg. is it possible to install both for switchover purposes?
>
> No idea. John?
I hadn't thought about this until you mentioned it!

They could very nearly coexist: the only clash is that they both have a
pgxml_parse function (the function is basically the same in both). The
other user function names in xml2 all begin xpath_ or xslt_, while in
xml they begin pgxml_. Perhaps the best solution is to rename the new
parse function - as it just returns a boolean for well-formedness,
xml_valid(text) might be a better name and would avoid the clash.

I'll give them a test together to make sure I haven't missed any other
problems and will submit an ordinary diff in the next couple of days to
change the function name (and the subdir in the Makefile, which should
be contrib/xml2 now).

Thanks

John

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-03-05 20:02:10 Re: Updated version of contrib/xml (at last)
Previous Message Andrew Dunstan 2004-03-05 17:38:13 Re: [HACKERS] Another crack at doing a Win32