Re: pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl start" f

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl start" f
Date: 2022-01-20 22:30:44
Message-ID: 1075553.1642717844@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

I wrote:
> What I'm thinking of doing is inventing a "soft_stop" variant of
> Cluster::stop that won't complain if pg_ctl stop fails, and then
> having 017_shm's poll_start() call that before retrying the start
> call.

I did that, modeling the details on Cluster::start's fail_ok option.

> It seems like it'd also be a good idea if the END block used
> soft_stop instead of regular stop.

I still like this idea, but I left it alone for the moment,
figuring I've used up my quota of buildfarm destabilization
for now.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-01-20 22:34:08 pgsql: Revert "Make configure prefer python3 to plain python."
Previous Message Tom Lane 2022-01-20 22:28:33 pgsql: Tighten TAP tests' tracking of postmaster state some more.