Re: Add support for automatically updating Unicode derived files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add support for automatically updating Unicode derived files
Date: 2020-01-20 15:43:32
Message-ID: 10754.1579535012@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 2020-01-15 01:37, Tom Lane wrote:
>> This patch is making src/tools/pginclude/headerscheck unhappy:
>> ./src/include/common/unicode_combining_table.h:3: error: array type has incomplete element type

> Hmm, this file is only meant to be included inside one particular
> function. Making it standalone includable would seem to be unnecessary.
> What should we do?

Well, we could make it a documented exception in headerscheck and
cpluspluscheck.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message 曾文旌 (义从) 2020-01-20 16:27:17 Re: [Proposal] Global temporary tables
Previous Message Luis Carril 2020-01-20 15:04:56 Re: Option to dump foreign data in pg_dump