| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add support for automatically updating Unicode derived files |
| Date: | 2020-01-20 08:59:34 |
| Message-ID: | 02d8b722-8c60-d039-ca00-7b74f09ff657@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-01-15 01:37, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> Committed, thanks.
>
> This patch is making src/tools/pginclude/headerscheck unhappy:
>
> ./src/include/common/unicode_combining_table.h:3: error: array type has incomplete element type
>
> I guess that header needs another #include, or else you need to
> move some declarations around.
Hmm, this file is only meant to be included inside one particular
function. Making it standalone includable would seem to be unnecessary.
What should we do?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2020-01-20 09:00:34 | Re: pgsql: Allow 'sslkey' and 'sslcert' in postgres_fdw user mappings |
| Previous Message | Heikki Linnakangas | 2020-01-20 08:44:28 | Re: Crash in BRIN summarization |