| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add option to use ICU as global locale provider |
| Date: | 2022-03-18 15:07:04 |
| Message-ID: | 1069623.1647616024@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Julien Rouhaud <rjuju123(at)gmail(dot)com> writes:
> That being said, we could save the result and explicitly close the collator.
> That wouldn't make much difference in initdb (but may be a bit cleaner), but I
> see that there's a similar coding in createdb(), which seems like it could leak
> some memory according to ucol_close man page.
FYI, I verified using valgrind that (as of HEAD) there is a leak
when creating a database with ICU collation that doesn't appear
when creating one with libc collation. It's not a lot, a few
hundred bytes per iteration, but it's there.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-03-18 17:10:12 | pgsql: Remove workarounds for avoiding [U]INT64_FORMAT in translatable |
| Previous Message | Julien Rouhaud | 2022-03-18 09:27:49 | Re: pgsql: Add option to use ICU as global locale provider |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maxim Orlov | 2022-03-18 15:14:52 | Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) |
| Previous Message | Tomas Vondra | 2022-03-18 14:43:41 | Re: Column Filtering in Logical Replication |