Re: building 7.4 with plperl

From: "Keith C(dot) Perry" <netadmin(at)vcsn(dot)com>
To: Gianni Mariani <gianni(at)mariani(dot)ws>
Cc: Postgres <pgsql-general(at)postgresql(dot)org>
Subject: Re: building 7.4 with plperl
Date: 2003-11-18 17:09:22
Message-ID: 1069175362.3fba524259b39@webmail.vcsn.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

Quoting Gianni Mariani <gianni(at)mariani(dot)ws>:

> Gianni Mariani wrote:
>
> >
> > Before I go deep into this - does anyone have the quick fix for this ?
> >
> > Some facts - the 7.3.4 version of plperl.c has the same errors in the
> > 7.4 tree.
> > The 7.4 version of plperl.c (with some error handling API calls
> > commented out) compiles fine in the 7.3.4 tree.
> > (Same machine - same install of perl !) Points to using some
> > alternate perl API probably by macro collision ?
>
> /* Define to 1 to build client libraries as thread-safe code.
> (--enable-thread-safety) */
> #define USE_THREADS 1
>
> So this seems to be the collision.
>
> --enable-thread-safety is a new option for libpq - however this collides
> with perl's use of the same macro.
>
> I suspect that the right answer would be to change the name USE_THREADS
> to PG_USE_THREADS for pg.
>
> Quick and nasty work around patch:
>
> --- plperl.c.7.4 Thu Sep 4 08:16:39 2003
> +++ plperl.c Mon Nov 17 23:07:05 2003
> @@ -55,6 +55,7 @@
> #include "catalog/pg_proc.h"
> #include "catalog/pg_type.h"
>
> +#undef USE_THREADS
> /* perl stuff */
> #include "EXTERN.h"
> #include "perl.h"
>
> another fix would be to make plplerl use the explicit api.
>
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
>

I had this same issue as well but now I'm *slightly* concerned since most of my
code is perl. How soon would issue be reviewed? (not that I'm NOT going to use
your patch for right now).

--
Keith C. Perry, MS E.E.
Director of Networks & Applications
VCSN, Inc.
http://vcsn.com

____________________________________
This email account is being host by:
VCSN, Inc : http://vcsn.com

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Keith C. Perry 2003-11-18 17:40:43 Re: building 7.4 with plperl (Updated)
Previous Message Fernando 2003-11-18 17:01:52 Lock questions