Re: pgsql: Set random seed for pgbench.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Set random seed for pgbench.
Date: 2018-03-31 16:34:32
Message-ID: 10686.1522514072@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> So this patch has ignored the possibility of not having pg_strong_random.

> I assumed that pg_strong_random is always available,

... which is wrong. Every other call of it is wrapped in
#ifdef HAVE_STRONG_RANDOM, and so must this one be.
We can use the same error message though, I suppose.

Adjusted and pushed.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Fabien COELHO 2018-03-31 17:43:38 Re: pgsql: Set random seed for pgbench.
Previous Message Tom Lane 2018-03-31 16:32:42 pgsql: Fix portability and translatability issues in commit 64f85894a.