Re: equal() perf tweak

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: equal() perf tweak
Date: 2003-11-05 09:24:45
Message-ID: 1068024285.779.10.camel@tokyo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Ok, I've attached new versions of list.c and pg_list.h -- this is just a
*rough sketch* of the new List code -- it definitely won't compile, the
intent is just to concretely specify the new List design. Also, I've
only updated the important list functions: I stopped at nth().

(I've attached the whole files, rather than diffs, because I thought
that would be easier to read...)

Any comments would be welcome -- I'm sure I've mucked a few things up.
Also, since it doesn't compile and I haven't done any testing, there are
probably some thinkos & typos in the code.

On Tue, 2003-11-04 at 11:40, Tom Lane wrote:
> Hmm ... taking that one step further, you could probably avoid the need
> for two palloc's in the first lcons/lappend if the List header were
> combined with the first ListCell. This would make for some grottiness
> in ldelete when removing the first list entry, but that's probably
> a good tradeoff.

I haven't implemented this (yet), or the aset.c changes you suggested.

-Neil

Attachment Content-Type Size
pg_list.h text/x-c-header 4.9 KB
list.c text/x-c 11.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Karel Zak 2003-11-05 09:29:01 Re: UPPER()/LOWER() and UTF-8
Previous Message Dave Page 2003-11-05 08:38:40 Re: Open Sourcing pgManage

Browse pgsql-patches by date

  From Date Subject
Next Message Larry Rosenman 2003-11-05 09:35:11 Re: UW 713UP3 patch
Previous Message Bruce Momjian 2003-11-05 09:23:35 Re: UW 713UP3 patch