Re: mcxt.c

From: Neil Conway <neilc(at)samurai(dot)com>
To: Gaetano Mendola <mendola(at)bigfoot(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: mcxt.c
Date: 2003-09-08 18:32:33
Message-ID: 1063045953.9051.48.camel@tokyo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Mon, 2003-09-08 at 11:09, Gaetano Mendola wrote:
> "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > I see no value at all in an assert. The code will dump core just fine
> > with or without an assert ...
>
> Right but an assert can display information about the file and line number
> without debug the application

I think the percentage of deployments that enable assertions (which
causes a runtime performance hit) but NOT debugging info (which does
not) is pretty small.

ISTM that checking for non-NULL pointers is pretty pointless: just
because a pointer happens to be non-NULL doesn't mean it is any more
valid, and dereferencing a NULL pointer is easy enough to track down in
any case.

-Neil

In response to

  • Re: mcxt.c at 2003-09-08 15:09:36 from Gaetano Mendola

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeroen Ruigrok/asmodai 2003-09-08 18:32:42 constraint modification on todo list
Previous Message Andrew Dunstan 2003-09-08 18:27:10 Re: plpgsql doesn't coerce boolean expressions to boolean

Browse pgsql-patches by date

  From Date Subject
Next Message Ron Mayer 2003-09-08 18:59:50 Re: ISO 8601 "Time Intervals" of the "format with time-unit deignators"
Previous Message Bruce Momjian 2003-09-08 17:02:11 Re: Minor lmgr code cleanup