| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: making EXPLAIN extensible |
| Date: | 2025-03-07 17:33:27 |
| Message-ID: | 1056391.1741368807@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Here's v6, doing it that way. I found that the simplest thing to do
> was just push the call to GetExplainExtensionId() inside
> Get/SetExplainExtensionState().
Fair enough.
> Tom, what do you think?
The header comments for explain_state.c could use a spellcheck.
I noticed s/offests/offsets/ and s/direcrtly/directly/.
Other than that, I think 0001 and 0002 are good to go.
I've still not looked at 0003.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-03-07 17:36:07 | Re: Parallel heap vacuum |
| Previous Message | Jacob Champion | 2025-03-07 17:30:52 | Re: [PoC] Federated Authn/z with OAUTHBEARER |