| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Caleb Welton <cwelton(at)pivotal(dot)io> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Issue with mkdtemp() in port.h |
| Date: | 2014-10-17 22:02:29 |
| Message-ID: | 10555.1413583349@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Caleb Welton <cwelton(at)pivotal(dot)io> writes:
> A little while back some users started complaining that the contrib module
> I develop (MADlib) was failing to build with the following error:
> /usr/include/postgresql/9.2/server/port.h:480:32: error: declaration of
> 'char* mkdtemp(char*)' has a different exception specifier
> /usr/include/stdlib.h:663:14: error: from previous declaration 'char*
> mkdtemp(char*) throw ()'
> After some research I've tracked this down to the following commit from ~4
> months ago:
> https://github.com/postgres/postgres/commit/a919937f112eb2f548d5f9bd1b3a7298375e6380
Hm. Looks like the extern that added should have been protected by
#ifndef HAVE_MKDTEMP
similarly to the other cases where we conditionally provide a substitute
function.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marko Tiikkaja | 2014-10-17 22:09:03 | Re: get_actual_variable_range vs idx_scan/idx_tup_fetch |
| Previous Message | Tom Lane | 2014-10-17 21:59:13 | Re: get_actual_variable_range vs idx_scan/idx_tup_fetch |