Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-01-31 15:08:30 -0500, Tom Lane wrote:
>> Done now.

> Thanks!

Just for the archives' sake --- seems this broke pademelon [1]:

cc -Ae -g +O0 -Wp,-H16384 +Z -I. -I. -I../../../src/include -D_XOPEN_SOURCE_EXTENDED -I/usr/local/libxml2-2.6.23/include/libxml2 -I/usr/local/include -DDEBUGGING -I/opt/perl5.8.9/lib/5.8.9/PA-RISC2.0-multi/CORE -c -o plperl.o plperl.c
...
cc: "plperl.c", line 669: error 1000: Unexpected symbol: "do".
cc: "plperl.c", line 669: error 1000: Unexpected symbol: "_sv".
cc: error 2017: Cannot recover from earlier errors, terminating.
make[3]: *** [plperl.o] Error 1

I've not tried to trace that in detail, but it seems clear that
something in the newer ppport.h is assuming a C99-compliant
compiler. I can hardly blame the Perl guys for assuming that
in 2022, so I'm just going to remove --with-perl from that
animal.

(It appears that Python 3 assumes C99-compliance too, in
a different way [2], so I've also had to remove --with-python.
Maybe I could resurrect that if I built Python 2.7 on that
machine, but I don't think I'm going to summon the motivation.
The world has clearly Moved On from pre-C99 compilers.)

regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelon&dt=2022-02-02%2000%3A47%3A30
[2] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelon&dt=2022-02-02%2000%3A21%3A18