Re: psql patch

From: Neil Conway <neilc(at)samurai(dot)com>
To: "Jeroen T(dot) Vermeulen" <jtv(at)xs4all(dot)nl>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: psql patch
Date: 2003-02-21 07:18:04
Message-ID: 1045811884.582.493.camel@tokyo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Thu, 2003-02-13 at 08:49, Jeroen T. Vermeulen wrote:
> Here's some changes I made last night to psql's common.c (as found in
> 7.3.2). It removes some code duplication and #ifdeffing, and some
> unstructured ugliness such as tacky breaks and an unneeded continue.
> Breaks up a large function into smaller functions and reduces required
> nesting levels, and kills a variable or two.

This patch breaks psql on my system:

(without the patch applied)

nconway=# \d
List of relations
Schema | Name | Type | Owner
--------+------+-------+---------
public | a | table | nconway
(1 row)

(with the patch applied)

nconway=> \d
nconway=>

Other slash commands (\d table, \df, etc.) are similarly broken.

Cheers,

Neil
--
Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC

In response to

  • psql patch at 2003-02-13 13:49:34 from Jeroen T. Vermeulen

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Christopher Kings-Lynne 2003-02-21 07:23:50 Re: [PATCHES] Non-colliding auto generated names
Previous Message Neil Conway 2003-02-21 05:32:57 Re: FAQ addition: deleteing all but one unique row