| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | andrewbille(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #16622: pg_dump produces erroneus ALTER TABLE statement for a table with an inherited generated column |
| Date: | 2020-09-21 21:20:22 |
| Message-ID: | 1040807.1600723222@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 18 Sep 2020, at 06:58, PG Bug reporting form <noreply(at)postgresql(dot)org> wrote:
>> psql:dump.sql:50: ERROR: column "b" of relation "gtest1_1" is a generated
>> column
> I can reproduce this in git HEAD too.
Yeah, this has been complained of before, notably at [1].
The latest patch in that thread is Masahiko-san's at [2],
which is similar to but not exactly like yours.
Could you review/test that one?
(I suspect you are right that binary-upgrade is a special case,
but wouldn't the existing pg_upgrade test catch that? Also,
do we need more test cases?)
regards, tom lane
[1] https://www.postgresql.org/message-id/flat/15830.1575468847%40sss.pgh.pa.us
[2] https://www.postgresql.org/message-id/CA%2Bfd4k6pLzrZDQsdsxcS06AwGRf1DgwOw84sFq9oXNw%2B83nB1g%40mail.gmail.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | İsmet BALAT | 2020-09-22 06:41:47 | Postgresql Bug Report |
| Previous Message | David Rowley | 2020-09-21 01:49:26 | Re: BUG #16624: Query Optimizer - Performance bug related to predicate simplification |