Re: postmaster segfaults when pg_hba.cof is missing

From: Neil Conway <neilc(at)samurai(dot)com>
To: Rudy Lippan <rlippan(at)remotelinux(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: postmaster segfaults when pg_hba.cof is missing
Date: 2002-12-12 22:54:22
Message-ID: 1039733662.354.32.camel@tokyo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches

On Thu, 2002-12-12 at 13:13, Rudy Lippan wrote:
> I know this is a broken install, but postmaster should not segfault when
> it can't find a file.
>
> postgres(at)war PGDATA $ ../pgsql7.3/bin/postmaster
> LOG: load_hba: Unable to open authentication config file
> "/usr/local/PGDATA/pgsql7.3/pg_hba.conf": No such file or directory
> Segmentation fault (core dumped)

Good catch. Here's a patch against CVS HEAD that fixes the problem.

The actual segfault was caused by a double pfree(), but ISTM that
failing to find pg_hba.conf should be a fatal error anyway, so I
increased the priority of the elog() from LOG to FATAL and refactored
the code a little bit.

Bruce: unless anyone has an objection, please apply.

Thanks for the report.

Cheers,

Neil

Attachment Content-Type Size
missing-hba-1.patch text/x-patch 974 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Neil Conway 2002-12-12 22:59:55 Re: Bug #847: plpgsql 'raise notice' > 4000 chars
Previous Message Bruce Momjian 2002-12-12 22:44:14 Re: Bug #838: SSL problems in 7.3

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-12-13 05:48:38 Re: pgsql ALTER command tab completion
Previous Message Bruce Momjian 2002-12-12 22:49:53 Re: PyGreSQL, suggestion for DB wrapper class