Re: Bug: COPY IN doesn't test domain constraints

From: Rod Taylor <rbt(at)rbt(dot)ca>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Bug: COPY IN doesn't test domain constraints
Date: 2002-09-17 15:19:32
Message-ID: 1032275973.32170.9.camel@jester
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Fixed this problem and added regression tests in domain.sql.

Also:
- Changed header file order (alphabetical)
- Changed to m = attnum - 1 in binary copy code for consistency

On Mon, 2002-09-16 at 17:54, Tom Lane wrote:
> In CVS tip:
>
> regression=# create domain nnint int not null;
> CREATE DOMAIN
> regression=# create table foo (f1 nnint);
> CREATE TABLE
> regression=# insert into foo values(null);
> ERROR: Domain nnint does not allow NULL values -- okay
> regression=# \copy foo from stdin
> 123
> \N
> \.
> regression=# select * from foo;
> f1
> -----
> 123
> -- not okay
> (2 rows)
>
> regression=# create domain vc4 varchar(4);
> CREATE DOMAIN
> regression=# create table foot (f1 vc4);
> CREATE TABLE
> regression=# \copy foot from stdin
> 1234567890
> \.
> regression=# select * from foot;
> f1
> ------------
> 1234567890 -- not okay
> (1 row)
>
>
> regards, tom lane
>
--
Rod Taylor

Attachment Content-Type Size
domain_copy.patch text/plain 12.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Sullivan 2002-09-17 15:19:44 Re: [GENERAL] Still big problems with pg_dump!
Previous Message Andrew Sullivan 2002-09-17 15:11:47 Re: [GENERAL] Still big problems with pg_dump!

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2002-09-17 15:44:32 trivial doc fix
Previous Message Bruno Wolff III 2002-09-17 12:42:49 earthdistance fixes, but no cube stuff