Re: possible self-deadlock window after bad ProcessStartupPacket

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Jimmy Yih <jyih(at)pivotal(dot)io>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: possible self-deadlock window after bad ProcessStartupPacket
Date: 2017-06-22 19:10:31
Message-ID: 10309.1498158631@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> Or, probably more robust: Simply _exit(2) without further ado, and rely
> on postmaster to output an appropriate error message. Arguably it's not
> actually useful to see hundreds of "WARNING: terminating connection because of
> crash of another server process" messages in the log anyway.

At that point you might as well skip the entire mechanism and go straight
to SIGKILL. IMO the only reason quickdie() exists at all is to try to
send a helpful message to the client. And it is helpful --- your attempt
to claim that it isn't sounds very much like wishful thinking.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-06-22 19:50:07 Re: Adding support for Default partition in partitioning
Previous Message Tom Lane 2017-06-22 18:11:08 Guarding against bugs-of-omission in initdb's setup_depend